Discussion:
[jetty-dev] [jira] Created: (JETTY-1292) SslSocketConnector.createFactory() leaks file handles when reading key/trust stores
(too old to reply)
Benjamin Bentmann (JIRA)
2010-10-19 19:50:32 UTC
Permalink
SslSocketConnector.createFactory() leaks file handles when reading key/trust stores
-----------------------------------------------------------------------------------

Key: JETTY-1292
URL: http://jira.codehaus.org/browse/JETTY-1292
Project: Jetty
Issue Type: Bug
Components: Security and SSL
Affects Versions: 6.1.25
Reporter: Benjamin Bentmann
Priority: Minor


The input streams passed to {{KeyStore.load()}} in {{SslSocketConnector.createFactory()}} aren't closed and leak the underlying file handle. In practice, we came across this when running unit tests using Jetty with a keystore loaded from a tmp file, on windows, the file couldn't be deleted after the tests finished.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Jesse McConnell (JIRA)
2010-10-19 20:06:32 UTC
Permalink
[ http://jira.codehaus.org/browse/JETTY-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240177#action_240177 ]

Jesse McConnell commented on JETTY-1292:
----------------------------------------

thanks benjamin, this fix ought to make it into the next release
Post by Benjamin Bentmann (JIRA)
SslSocketConnector.createFactory() leaks file handles when reading key/trust stores
-----------------------------------------------------------------------------------
Key: JETTY-1292
URL: http://jira.codehaus.org/browse/JETTY-1292
Project: Jetty
Issue Type: Bug
Components: Security and SSL
Affects Versions: 6.1.25
Reporter: Benjamin Bentmann
Priority: Minor
The input streams passed to {{KeyStore.load()}} in {{SslSocketConnector.createFactory()}} aren't closed and leak the underlying file handle. In practice, we came across this when running unit tests using Jetty with a keystore loaded from a tmp file, on windows, the file couldn't be deleted after the tests finished.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Jesse McConnell (JIRA)
2010-10-19 22:58:33 UTC
Permalink
[ http://jira.codehaus.org/browse/JETTY-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240205#action_240205 ]

Jesse McConnell commented on JETTY-1292:
----------------------------------------

also, I checked through jetty7 and didn't find any mainline code instances of this issue, they were all correctly closing the input stream...found a spot or two in unit tests that might be an issue and will resolve those
Post by Benjamin Bentmann (JIRA)
SslSocketConnector.createFactory() leaks file handles when reading key/trust stores
-----------------------------------------------------------------------------------
Key: JETTY-1292
URL: http://jira.codehaus.org/browse/JETTY-1292
Project: Jetty
Issue Type: Bug
Components: Security and SSL
Affects Versions: 6.1.25
Reporter: Benjamin Bentmann
Assignee: Jesse McConnell
Priority: Minor
Fix For: 6.1.26
The input streams passed to {{KeyStore.load()}} in {{SslSocketConnector.createFactory()}} aren't closed and leak the underlying file handle. In practice, we came across this when running unit tests using Jetty with a keystore loaded from a tmp file, on windows, the file couldn't be deleted after the tests finished.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Jesse McConnell (JIRA)
2010-10-19 22:58:33 UTC
Permalink
[ http://jira.codehaus.org/browse/JETTY-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse McConnell resolved JETTY-1292.
------------------------------------

Resolution: Fixed
Fix Version/s: 6.1.26
Assignee: Jesse McConnell

resolved on trunk and greg is porting over to release tag I believe
Post by Benjamin Bentmann (JIRA)
SslSocketConnector.createFactory() leaks file handles when reading key/trust stores
-----------------------------------------------------------------------------------
Key: JETTY-1292
URL: http://jira.codehaus.org/browse/JETTY-1292
Project: Jetty
Issue Type: Bug
Components: Security and SSL
Affects Versions: 6.1.25
Reporter: Benjamin Bentmann
Assignee: Jesse McConnell
Priority: Minor
Fix For: 6.1.26
The input streams passed to {{KeyStore.load()}} in {{SslSocketConnector.createFactory()}} aren't closed and leak the underlying file handle. In practice, we came across this when running unit tests using Jetty with a keystore loaded from a tmp file, on windows, the file couldn't be deleted after the tests finished.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Loading...